jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Added support for metadata and tags to Azure ARM (#327)
Date Mon, 17 Oct 2016 13:04:25 GMT
andreaturli commented on this pull request.



> @@ -177,10 +176,9 @@ public String apply(VirtualMachineStatus input) {
       builder.privateAddresses(getPrivateIpAddresses(virtualMachine.properties().networkProfile().networkInterfaces()));
 
       if (virtualMachine.tags() != null) {
-         Map<String, String> userMetaData = virtualMachine.tags();
-         builder.userMetadata(userMetaData);
-         builder.tags(Splitter.on(",").split(userMetaData.get("tags")));
+         addMetadataAndParseTagsFromCommaDelimitedValue(builder, virtualMachine.tags());

nice! didn't know it 👍 


-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/327#pullrequestreview-4467641
Mime
View raw message