jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds/jclouds] Use file.separator in tests instead of slash (#1021)
Date Thu, 13 Oct 2016 23:49:01 GMT
andrewgaul requested changes on this pull request.



> @@ -584,12 +584,12 @@ public void testListMarkerPrefix() throws Exception {
       final String container = getContainerName();
       try {
          blobStore.createContainerInLocation(null, container);
-         blobStore.putBlob(container, blobStore.blobBuilder("a/a").payload("").build());
-         blobStore.putBlob(container, blobStore.blobBuilder("b/b").payload("").build());
-         ListContainerOptions options = new ListContainerOptions().afterMarker("b/").recursive();
+         blobStore.putBlob(container, blobStore.blobBuilder("a" + File.separator + "a").payload("").build());

This is backwards -- the Filesystem blobstore should map the path separator and not the tests.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1021#pullrequestreview-4187901
Mime
View raw message