jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zack Shoylev <notificati...@github.com>
Subject Re: [jclouds/jclouds] Ensure that jclouds filesystem provider consistently uses / (#1024)
Date Wed, 26 Oct 2016 04:14:47 GMT
zack-shoylev commented on this pull request.



>      * @return
     */
-   private static String normalize(String pathToBeNormalized) {
-      if (null != pathToBeNormalized && pathToBeNormalized.contains(BACK_SLASH))
{
-         if (!BACK_SLASH.equals(File.separator)) {
-            return pathToBeNormalized.replace(BACK_SLASH, File.separator);
-         }
+   private static String normalize(String path) {
+      if (null != path) {

But then it is not cross-platform. I mean, it's fairly easy to put the exception in, but a
real fix will probably be somewhat more complex (i.e. hex-encoding the blob name). But I do
get we want to keep this a filesystem provider, so it makes sense to have it follow the filesystem
closely. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1024
Mime
View raw message