jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds/jclouds-karaf] Take into account the credentials file in GCE (#87)
Date Fri, 11 Nov 2016 19:21:23 GMT
demobox commented on this pull request.



>                    String endpointValue = EnvHelper.getComputeEndpoint(endpoint);
+                  String credentialValue = EnvHelper.getComputeCredential(credential);
+                  if (providerValue != null && credentialValue != null &&
providerValue.equals("google-compute-engine")) {
+                     credentialValue = EnvHelper.getGoogleCredentialFromJsonFile(credentialValue);

If I understand this correctly, we're effectively adding fallback logic - "try normal first,
if that doesn't work, try the JSON file". Is that the same sequence as in the provide? Is
there some property that we could use to determine up front which of the two options is being
used?

Also, as a minor change, check `credentialValue != null` first?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/87#pullrequestreview-8251044
Mime
View raw message