jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-karaf] Take into account the credentials file in GCE (#87)
Date Mon, 21 Nov 2016 11:49:02 GMT
nacx commented on this pull request.



>                    String endpointValue = EnvHelper.getComputeEndpoint(endpoint);
+                  String credentialValue = EnvHelper.getComputeCredential(credential);
+                  if (providerValue != null && credentialValue != null &&
providerValue.equals("google-compute-engine")) {
+                     credentialValue = EnvHelper.getGoogleCredentialFromJsonFile(credentialValue);

There is no property in the provider. There is a property used in the tests, to denote the
json file, but when instantiating the google provider, if you cant to use the json file you
need to pass the [GoogleCredentialsFromJson](https://github.com/jclouds/jclouds/blob/master/common/googlecloud/src/main/java/org/jclouds/googlecloud/GoogleCredentialsFromJson.java)
credential supplier yourself instead of the credential when creating the context.

>Also, as a minor change, check credentialValue != null first?

Done!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/87
Mime
View raw message