jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds/jclouds-karaf] Properly encapsulate google credential processing (#88)
Date Thu, 24 Nov 2016 01:37:23 GMT
demobox commented on this pull request.

Thanks for the cleanup, @nacx! Also: do we need to make any updates to other projects for
this?

> @@ -238,4 +240,12 @@ private static String getValueOrPropertyOrEnvironmentVariable(
         }
         return value;
     }
+    
+   private static String getCredentialValue(String provider, String credential) {
+      return credential != null && isGoogleCloud(provider) ? getGoogleCredentialFromJsonFileIfPath(credential)
: credential;
+   }
+   
+   private static boolean isGoogleCloud(String provider) {
+      return provider != null && provider.startsWith("google");

Do we need this safety check? Is provider ever legitimately `null`?

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/88#pullrequestreview-9969872
Mime
View raw message