jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds] org/jclouds/scriptbuilder/functionloader/osgi/BundleFunctionLoader.java: (#1033)
Date Thu, 03 Nov 2016 07:37:54 GMT
Ok. The issue seems to appear because you depend on [osgi.core v6](https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/jclouds-scriptbuilder/jclouds-scriptbuilder-1.9.2-r1.ebuild#L25),
while the code assumes [version 4.2.0](https://github.com/jclouds/jclouds/blob/master/scriptbuilder/pom.xml#L62).

In version 6, the `BundleContex.registerService` signature changes the type of the lat parameter
from `Dictionary` (raw type) to `Dictionary<String, ?>`, and since the `Properties`
object extends `HasMap<Object, Object>` it no longer matches the signature.

The build fails with your changes (see [this](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/2473/org.apache.jclouds$jclouds-scriptbuilder/console)
for details), so changes are needed.

* Can you just make the ebuild depend on osgi core 4.2.0?
* It would be great to extract the osgi core version to jclouds/project/pom.xml so we can
easily run a build with a custom version of the osgi framework. This would allow us to create
a build compatibility matrix and add it to our CI.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1033#issuecomment-258078992
Mime
View raw message