jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds] Make jclouds compatible with newer OSGi framework versions (#1034)
Date Thu, 03 Nov 2016 09:21:47 GMT
nacx commented on this pull request.



> @@ -20,3 +20,4 @@ com/google/common/primitives/Longs.compare:(JJ)I
 com/google/inject/Inject
 com/google/inject/Provider
 java/lang/StringBuffer."<init>":()V
+java/util/Hashtable."<init>":(I)V

@andrewgaul Note that the signatures of the OSGi framework require a `Dictionary<String,
?>`, and the properties object is no longer compatible, as it extends `Hashtable<Object,
Object>`. We need to pass a proper dictionary there, thus this exclusion (`HashMap` does
not extend `Dictionary`).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1034#pullrequestreview-6969233
Mime
View raw message