jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds] Make jclouds compatible with newer OSGi framework versions (#1034)
Date Thu, 03 Nov 2016 09:55:47 GMT
nacx commented on this pull request.



> @@ -20,3 +20,4 @@ com/google/common/primitives/Longs.compare:(JJ)I
 com/google/inject/Inject
 com/google/inject/Provider
 java/lang/StringBuffer."<init>":()V
+java/util/Hashtable."<init>":(I)V

No, I meant `HashMap`. The modernizer plugin forbids the use of Hashtable in favor of HashMap,
but HashMap does not extend Dictionary. Thus it can't be used as an argument to the BundleContext.registerService
method. That's why I just excluded it from modernizer, as we now actually need a Hashtable
instance. See [this comment](https://github.com/jclouds/jclouds/pull/1033#issuecomment-258078992)
for further details.

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1034
Mime
View raw message