jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds/jclouds] Use temporary file for Swift test inputs (#1035)
Date Thu, 10 Nov 2016 02:07:18 GMT
demobox commented on this pull request.



> @@ -679,7 +679,7 @@ public void downloadBlob(String container, String name, File destination,
Execut
 
       ListeningExecutorService listeningExecutor = MoreExecutors.listeningDecorator(executor);
       RandomAccessFile raf = null;
-      File tempFile = new File(destination.getName() + "." + UUID.randomUUID());
+      File tempFile = new File(destination + "." + UUID.randomUUID());

Is `destination` here an absolute known/assumed to be an absolute path?

> @@ -121,7 +126,7 @@ public void uploadMultipartBlob() {
 
    @Test(dependsOnMethods = "uploadMultipartBlob", singleThreaded = true)
    public void downloadParallelBlob() throws IOException {
-      final File downloadedFile = new File(BIG_FILE.getName() + ".downloaded");
+      final File downloadedFile = new File(BIG_FILE + ".downloaded");

I was going to suggest making this name random across test runs, but given the way `BIG_FILE`
is created, that should already be the case? Just wanting to make sure I'm not missing something
here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1035#pullrequestreview-7934698
Mime
View raw message