jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrea Turli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCLOUDS-1221) features should come from jclouds/jclouds only?
Date Thu, 05 Jan 2017 15:38:58 GMT

    [ https://issues.apache.org/jira/browse/JCLOUDS-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801671#comment-15801671
] 

Andrea Turli commented on JCLOUDS-1221:
---------------------------------------

I'm not entirely sure it would help :D
{code}
    <feature name="jclouds-services" description="OSGi Service Factories for jclouds" version="${project.version}"
resolver="(obr)">
        <configfile finalname="/etc/org.apache.jclouds.credentials.cfg">mvn:org.apache.jclouds.karaf/jclouds-karaf/${project.version}/cfg/credentials</configfile>
        <feature version='${project.version}'>jclouds-compute</feature>
        <feature version='${project.version}'>jclouds-blobstore</feature>
        <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.jsch/${jsch.bundle.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.jclouds.karaf.bundles/jsch-agentproxy-jsch/${project.version}</bundle>
        <bundle dependency='true'>mvn:com.jcraft/jsch.agentproxy.connector-factory/${jsch.agentproxy.version}</bundle>
        <bundle dependency='true'>mvn:com.jcraft/jsch.agentproxy.usocket-nc/${jsch.agentproxy.version}</bundle>
        <bundle dependency='true'>mvn:com.jcraft/jsch.agentproxy.sshagent/${jsch.agentproxy.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.jzlib/${jzlib.bundle.version}</bundle>
        <bundle dependency='true'>mvn:org.bouncycastle/bcprov-ext-jdk15on/${bcprov.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.jclouds.driver/jclouds-bouncycastle/${jclouds.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.jclouds.driver/jclouds-slf4j/${jclouds.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.jclouds.common/googlecloud/${jclouds.version}</bundle>
        <bundle>mvn:org.apache.jclouds.driver/jclouds-jsch/${jclouds.version}</bundle>
        <bundle>mvn:org.apache.jclouds.driver/jclouds-log4j/${jclouds.version}</bundle>
        <bundle>mvn:org.apache.jclouds.karaf/core/${project.version}</bundle>
        <bundle>mvn:org.apache.jclouds.karaf/cache/${project.version}</bundle>
        <bundle>mvn:org.apache.jclouds.karaf/recipe/${project.version}</bundle>
        <bundle>mvn:org.apache.jclouds.karaf/services/${project.version}</bundle>
    </feature>
{code}

I think here we are missing some `drivers` like okhttp and this means that docker and azurecompute-arm
features will need both something like:
{code}
    <feature name='jclouds-api-docker' description='jclouds - API - Docker' version='${project.version}'
resolver='(obr)'>
        <feature version='${project.version}'>jclouds-compute</feature>
        <bundle dependency='true'>mvn:org.apache.jclouds.api/oauth/${jclouds.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.okio/${okio.bundle.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.okhttp/${okhttp.bundle.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.jclouds.driver/jclouds-okhttp/${jclouds.version}</bundle>
        <bundle>mvn:org.apache.jclouds.api/docker/${jclouds.version}</bundle>
    </feature>
{code}

so in my mind something like (not tested!) looks more re-usable:
{code}
    <feature name='jclouds-driver-okhttp' description='jclouds - Driver - OkHttp' version='${project.version}'
resolver='(obr)'>
        <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.okio/${okio.bundle.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.okhttp/${okhttp.bundle.version}</bundle>
        <bundle dependency='true'>mvn:org.apache.jclouds.driver/jclouds-okhttp/${jclouds.version}</bundle>
    </feature>
{code}

as it will allow us to write

{code}
    <feature name='jclouds-api-docker' description='jclouds - API - Docker' version='${project.version}'
resolver='(obr)'>
        <feature version='${project.version}'>jclouds-compute</feature>
        <feature version='${project.version}'>jclouds-driver-oktthp</feature>
        <bundle>mvn:org.apache.jclouds.api/docker/${jclouds.version}</bundle>
    </feature>
{code}

but I'm not entirely sure it is the karaf way :)

> features should come from jclouds/jclouds only?
> -----------------------------------------------
>
>                 Key: JCLOUDS-1221
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1221
>             Project: jclouds
>          Issue Type: Improvement
>          Components: jclouds-karaf
>            Reporter: Andrea Turli
>            Priority: Minor
>
> I'm trying to update the feature.xml file in jclouds-karaf and I've notice that there
are feature that reference bundles coming from `mvn:org.apache.jclouds.labs` 
> As per the nature of jclouds-labs project, some providers may also never be promoted
so I'm not sure jclouds-karaf should reference them. This make the jclouds-karaf maintenance
complicated IMHO



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message