jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Vagrant provider (#160)
Date Mon, 09 Jan 2017 20:43:55 GMT
nacx commented on this pull request.



> +public abstract class VagrantComputeServiceAdapterLiveTest extends BaseComputeServiceLiveTest
{
+
+   public VagrantComputeServiceAdapterLiveTest() {
+      provider = "vagrant";
+   }
+
+   @Override
+   protected Module getSshModule() {
+      return new SshjSshClientModule();
+   }
+
+   @Override
+   protected TemplateBuilder templateBuilder() {
+      return super.templateBuilder()
+         .imageId(getImageId());
+   }

I've just seen this. Instead of hardcoding the fact that you want to use a custom image to
run the tests, use the existing "jclouds.template" property.

You can configure a default value in the pom.xml (like in [digitalocean2](https://github.com/jclouds/jclouds/blob/master/providers/digitalocean2/pom.xml#L151)
for example), and run the tests with `-Dtest.vagrant.template="imageId=foo/bar"`. This will
keep the tests aligned with the rest of the providers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#pullrequestreview-15790900
Mime
View raw message