jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Oneandone compute api (#338)
Date Fri, 13 Jan 2017 22:17:35 GMT
nacx commented on this pull request.



> +      
+      //if no private key was set use the set/generated password.
+      if (privateKey == null) {
+         serverCredentials = LoginCredentials.builder()
+                 .user(loginUser)
+                 .password(password)
+                 .build();
+      } else {
+         serverCredentials = LoginCredentials.builder()
+                 .user(loginUser)
+                 .privateKey(privateKey)
+                 .build();
+
+      }
+
+      return new NodeAndInitialCredentials<Server>(server, server.id(), serverCredentials);

In that case, would it make sense to set it to null if the user configured the credentials
explicitly, otherwise, read that response and manually set the generated credentials here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/338
Mime
View raw message