jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Oneandone compute api (#338)
Date Fri, 27 Jan 2017 23:21:15 GMT
nacx commented on this pull request.



>     }
 
    @Override
-   public List<HardwareFlavour> listHardwareProfiles() {
-      return api.serverApi().listHardwareFlavours();
+   public List<Hardware> listHardwareProfiles() {

If they are predefined, then they are valid for the provider and we should respectand use
them (have you checked that jclouds and the provider use the same units?). In this case I
think we'd rather override the assertions in the live tests instead of conditioning the provider
logic to them, and get back the old flavor logic.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/338
Mime
View raw message