jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] add AddApiVersionToRequest filter (#343)
Date Sat, 14 Jan 2017 15:56:28 GMT
andreaturli commented on this pull request.

>        assertEquals(request.getHeader("X-Auth-Token"), X_AUTHORIZATION_TOKEN);
       return request;
    protected RecordedRequest assertSent(MockWebServer server, String method, String path,
String json)
          throws InterruptedException {
       RecordedRequest request = assertSent(server, method, path);
-      assertEquals(request.getHeader("Content-Type"), "application/json");
+      assertEquals(request.getHeader("Accept"), "application/json; version=" + ctx.getMetadata().get("apiVersion"));

addressed and rebased, I think it is ready for being merged.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
View raw message