jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alibazlamit <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-1208 Implement the TemplateOptions.inboundPorts in ProfitBricks REST (#344)
Date Mon, 23 Jan 2017 13:30:43 GMT
alibazlamit commented on this pull request.



> +         int matches = 0;
+         client.getSecurityGroupExtension();
+         NodeMetadata node = getOnlyElement(client.createNodesInGroup(group + "inbound",
1, template));
+         DataCenterAndId datacenterAndId = DataCenterAndId.fromSlashEncoded(node.getId());
+         ProfitBricksApi pbApi = client.getContext().unwrapApi(ProfitBricksApi.class);
+         Server server = pbApi.serverApi().getServer(datacenterAndId.getDataCenter(), datacenterAndId.getId(),
new DepthOptions().depth(5));
+         for (FirewallRule rule : server.entities().nics().items().get(0).entities().firewallrules().items())
{
+            if (rule.properties().portRangeStart() == 80 || rule.properties().portRangeStart()
== 22 || rule.properties().portRangeStart() == 443) {
+               matches++;
+            }
+         }
+         Assert.assertEquals(3, matches);
+      } finally {
+         client.destroyNodesMatching(inGroup(group + "inbound"));
+      }
+   }

Do you mean to call the super `testCreateAndRunAService` or the `createAndRunAServiceInGroup`,
if i override the `createAndRunAServiceInGroup` i still have to create an additional test
since its not a test its just a method?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/344
Mime
View raw message