jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)
Date Mon, 23 Jan 2017 16:49:24 GMT
nacx commented on this pull request.



> +
+       private static class Devices extends PaginatedCollection<Device> {
+         @ConstructorProperties({"devices", "meta"})
+         public Devices(List<Device> items, Meta meta) {
+            super(items, meta);
+         }
+      }
+
+      public static class ToPagedIterable extends Arg0ToPagedIterable.FromCaller<Device,
ToPagedIterable> {
+
+         private final PacketApi api;
+         private final Function<Href, ListOptions> hrefToOptions;
+
+         @Inject
+         protected ToPagedIterable(PacketApi api, Function<Href, ListOptions> hrefToOptions)
{
+            this.api = checkNotNull(api, "api");

Remove the redundant check and the protected modifier from the constructor

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/345#pullrequestreview-17968889
Mime
View raw message