jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)
Date Mon, 23 Jan 2017 16:51:33 GMT
nacx commented on this pull request.



> @@ -73,7 +72,7 @@ public void testCreate() {
                       .tags(ImmutableSet.<String> of())
                       .build()
       );
-      deviceId = URIs.toId(deviceCreated);
+      deviceId = deviceCreated.id();
       assertNodeRunning(deviceId);
       Device device = api().get(deviceId);
       assertNotNull(device, "Device must not be null");

Add a test for the `actions` method too?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/345#pullrequestreview-17969475
Mime
View raw message