jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] [azurecompute-arm] performance improvements misc (#351)
Date Fri, 27 Jan 2017 10:30:34 GMT
nacx requested changes on this pull request.

[This](https://github.com/jclouds/jclouds-labs/blob/master/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/functions/VMImageToImage.java#L178-L188)
needs to be removed or modified.
Would it make sense to add code there to perform the call to get the version properties, if
the VMImage object contains all the necessary info? This way we could keep the information
more complete.
Do we know how many UNRECOGNIZED images we have? If the number is considerable, then introducing
such a call would invalidate the improvement made in the `listImages` method, but if there
are just few, the code would be executed rarely and we'd have better images. WDYT?

> + *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+
+@AutoValue
+public abstract class Identity {

Is there any reason why this class is not an inner class of Resource?

> @@ -76,12 +78,20 @@
    @Nullable
    ResourceGroup get(@PathParam("name") String name);
 
+   @Named("resourcegroup:resources")
+   @GET
+   @Path("/{name}/resources")
+   @SelectJson("value")
+   @Fallback(EmptyListOnNotFoundOr404.class)
+   @Nullable

Given the configured fallback the returned link is never going to be null.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/351#pullrequestreview-18810697
Mime
View raw message