jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Load existing machines info on startup (#355)
Date Tue, 31 Jan 2017 22:19:24 GMT
nacx commented on this pull request.



> @@ -73,36 +93,41 @@ public long getDelay(TimeUnit unit) {
          return unit.convert(expiryTime - timeSupplier.get(), TimeUnit.MILLISECONDS);
       }
    }
-   private Map<String, VagrantNode> nodes = new ConcurrentHashMap<String, VagrantNode>();
-   private DelayQueue<TerminatedNode> terminatedNodes = new DelayQueue<TerminatedNode>();
+
+   private final DelayQueue<TerminatedNode> terminatedNodes = new DelayQueue<TerminatedNode>();

Hmmm... AFAIK that only happens in AWS because the nodes don't disappear directly. jclouds
expects the nodes to be gone or in terminated state (as per the [node terminated predicate](https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/predicates/AtomicNodeTerminated.java)).
This looks great and we've learned something! But we'd better keep the code as simple as possible.
Could you try removing the terminated node cache and test the provider if you just completely
remove the machines? It should still work as expected.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/355
Mime
View raw message