jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CARRIERE Etienne <notificati...@github.com>
Subject [jclouds/jclouds] JCLOUDS-1220 : Managing the header name in the TempAuth (Identity Protocol v1) (#1046)
Date Tue, 03 Jan 2017 17:19:04 GMT
State of jclouds
The openstack swift "official" client (in python) manage this v1 protocol (http://docs.openstack.org/developer/python-swiftclient/swiftclient.html)
so even if we don't have a specification, we will use the code of the official client for
the implementation.

In jclouds, there is currently a sort-of v1 identity protocol in the openstack-swift module:
in apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/config/SwiftAuthenticationModule.java,
there is a tempAuthCredentials which is almost the identity v1 protocol except that the name
of the headers was not the same :
= X-Storage-User vs X-Auth-User
= X-Storage-Path vs X-Auth-Key

Pull request :
= Keep the current behaviour as default
= Add 2 parameters to change the header name through variables in the Properties put in the
Builder like that :

Properties overrides = new Properties();
overrides.setProperty("jclouds.keystone.credential-type", "tempAuthCredentials");
overrides.setProperty("jclouds.swift.tempAuth.headerUser", "X-Auth-User");
overrides.setProperty("jclouds.swift.tempAuth.headerPass", "X-Auth-Pass");
swiftApi = ContextBuilder.newBuilder(provider)
.endpoint(args[1])
.credentials(identity, credential)
.modules(modules)
.overrides(overrides)
.buildApi(SwiftApi.class);

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1046

-- Commit Summary --

  * Possibility to change the name of Header of Identity v1 protocol

-- File Changes --

    A apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/binders/TempAuthBinder.java
(40)
    M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/config/SwiftAuthenticationModule.java
(32)
    M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/TempAuthMockTest.java
(26)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1046.patch
https://github.com/jclouds/jclouds/pull/1046.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1046

Mime
View raw message