jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Fix NPE in building node metadata (#367)
Date Thu, 02 Mar 2017 21:21:40 GMT
andreaturli commented on this pull request.



> @@ -179,8 +180,15 @@ public String apply(Status input) {
       Credentials credentials = credentialStore.get("node#" + virtualMachine.name());
       builder.credentials(LoginCredentials.fromCredentials(credentials));
 
-      builder.publicAddresses(getPublicIpAddresses(virtualMachine.properties().networkProfile().networkInterfaces()));

I  think the NPE can come from `virtualMachine.properties().networkProfile().networkInterfaces()`
as `networkProfile` can be null. Can you guard against this one ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/367#pullrequestreview-24786905
Mime
View raw message