jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)
Date Sat, 18 Mar 2017 08:14:39 GMT
andreaturli commented on this pull request.

a minor comment, but overall looks good

> @@ -54,6 +54,7 @@
    protected String networkSecurityGroupName;
    protected String reservedIPName;
    protected Boolean provisionGuestAgent;
+   protected Boolean winrmUseHttps;

isn't `String listenerProtocol` a better model ? we can then add a `ListenerProtocol` enum
like:
```
   public enum ListenerProtocol {

      HTTP("Http"),
      HTTPS("Https");

      private String value;

      ListenerProtocol(String value) {
         this.value = value;
      }

      public static ListenerProtocol fromString(String value) {
         ListenerProtocol[] items = ListenerProtocol.values();
         for (ListenerProtocol item : items) {
            if (item.toString().equalsIgnoreCase(value)) {
               return item;
            }
         }
         return new IllegalArgumentException("Cannot find an enum for " + value);
      }

      @Override
      public String toString() {
         return this.value;
      }
   }
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/371#pullrequestreview-27719776
Mime
View raw message