jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Adding Dimension Data ServerImageAPI (#380)
Date Fri, 07 Apr 2017 11:07:00 GMT
nacx commented on this pull request.



> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.dimensiondata.cloudcontrol.domain;
+
+import com.google.auto.value.AutoValue;
+import com.google.common.collect.ImmutableList;
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import java.util.Date;
+import java.util.List;
+
+@AutoValue
+public abstract class CustomerImage extends BaseImage {

Take special care with inheritance. For serialization/deserialization we rely on the order
in which fields are declared. It must match the one in the factory method annotation. With
inheritance in place, IIRC fields from the parent class come first, but you'd better confirm
that. In any case, inheritance should be treated *very carefully* or not used.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/380#discussion_r110366421
Mime
View raw message