jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Trevor Flanagan <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Adding Dimension Data ServerImageAPI (#380)
Date Tue, 11 Apr 2017 09:29:01 GMT
trevorflanagan commented on this pull request.



> +                              .build()).vmTools(
+                        VmTools.builder().versionStatus("CURRENT").runningStatus("NOT_RUNNING").apiVersion(9354)
+                              .type("VMWARE_TOOLS").build()).osCustomization(true).build())
+                  .virtualHardware(VirtualHardware.builder().version("vmx-08").upToDate(false).build())
+                  .tags(ImmutableList.of(CustomerImage.TagWithIdAndName.builder().tagKeyName("DdTest3")
+                              .tagKeyId("ee58176e-305b-4ec2-85e0-330a33729a94").build(),
+                        CustomerImage.TagWithIdAndName.builder().tagKeyName("Lukas11")
+                              .tagKeyId("c5480364-d3cd-4391-9536-5c1af683a8f1").value("j").build(),
+                        CustomerImage.TagWithIdAndName.builder().tagKeyName("Lukas5")
+                              .tagKeyId("a3e869df-6427-404f-99c2-b50f526369aa").build()))
+                  .softwareLabels(ImmutableList.<String>of()).nics(ImmutableList.<ImageNic>of()).source(
+                        CustomerImage.Source.builder().artifacts(ImmutableList
+                              .of(CustomerImage.Artifact.builder().value("cb4b8674-09a4-4194-9593-9cdc81489de1")
+                                    .type("SERVER_ID").build())).type("CLONE").build()).build());
+      return new CustomerImages(customerImages, 1, 2, 2, 250);
+   }

Understood @nacx. I have added an assertion to the `CustomerImagesParseTest` and  `OsImagesParseTest`
classes. The `type` value is not returned from the API so no serialization work required.
We intend to use this piece of information in a future piece of functionality.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/380#discussion_r110854903
Mime
View raw message