jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-1273: Support multiple resource groups in ARM (#385)
Date Tue, 25 Apr 2017 06:35:24 GMT
nacx commented on this pull request.



>  
-      getOrCreateVirtualNetworkWithSubnet(location, options, azureGroupName);
-      configureSecurityGroupForOptions(group, azureGroupName, template.getLocation(), options);
+      createResourceGroupIfNeeded(group, location, options);

I'm not really sure about this. If we do so, we should expose the method in the options that
requires the object, which is not very convenient when it does not exist and you expect jclouds
to create it for you. One possible option would be to keep the method to set the name, and
add one to provide the ResourceGroup object, but that does not fix the side effect here: even
if an object is set in the options, we need to check if that resource group exists and create
it if missing, so the logic would be pretty much the same.
Regarding the jclouds code that consumes the resourceGroup option, the only thing that is
used is actually the name, to create the different feature APIs, so the object is not really
needed internally.
Thoughts?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/385#discussion_r113116368
Mime
View raw message