jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoff Macartney <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-1278: Allow to configure virtual machine NICs in Azure ARM (#386)
Date Thu, 27 Apr 2017 15:19:05 GMT
geomacy commented on this pull request.



> @@ -75,13 +75,26 @@ public AzureTemplateOptions dataDisks(DataDisk... dataDisks) {
       return dataDisks(ImmutableList.copyOf(checkNotNull(dataDisks, "dataDisks")));
    }
    
+   /**
+    * Configure the NICs that will be attached to the created nodes.
+    * <p>
+    * Note that the number of NICs that can be attached depends on the size of
+    * the virtual machine, and that the guest operating system needs to be
+    * prepared to setup ont only the first network interface.
+    * <p>
+    * Depending on the image being used, a cloud-init or bootstrap script might
+    * be needed to make the interface setup.

is it worth adding a distinction between the main NIC which will normally(?) be attached,
and additional ones that won't?  Or do you mean above 
"and that the guest operating system will typically set up only the first network interface."


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/386#pullrequestreview-35138766
Mime
View raw message