jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mat Mannion <notificati...@github.com>
Subject [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)
Date Mon, 03 Apr 2017 13:54:38 GMT
This fix calls urlEncode on the path before appending them to the existing path, as the core
UriBuilder
class expects them to be URL-encoded.

I'm not overly enamoured with this fix, it seems wasteful to encode something for it to be
immediately decoded, but equally I'm nervous about making changes to jclouds-core and this
seemed to be the easiest drop-in fix for the underlying issue.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1084

-- Commit Summary --

  * JCLOUDS-1263: URL encode object names from list object response before creating URIs with
them

-- File Changes --

    M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/functions/ParseObjectListFromResponse.java
(5)
    M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiMockTest.java
(4)
    M apis/openstack-swift/src/test/resources/object_list.json (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1084.patch
https://github.com/jclouds/jclouds/pull/1084.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1084

Mime
View raw message