jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Estévez <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)
Date Tue, 27 Jun 2017 14:39:25 GMT
danielestevez commented on this pull request.



> +/**
+ *
+ */
+@AutoValue
+public abstract class MetricData {
+
+   /**
+    * The timestamp for the metric value in ISO 8601 format.
+    */
+   public abstract Date timeStamp();
+
+   /**
+    * The average value in the time range
+    */
+   @Nullable
+   public abstract String total();

Ok, we could get Double for all fields but i still think we should return a String as Azure
API does. If we force Double for let's say "total" this could be ok for metrics in bytes (as
Network In) but would make no sense for metrics with no decimals (like Disk Read Operations/Sec
that is a smaller count that could be even Int)

Since jclouds will not do any calculations with these values i think we should return them
as they are and let the user decide how to parse them.

Thoughts?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/396#discussion_r124293765
Mime
View raw message