jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)
Date Tue, 27 Jun 2017 15:06:54 GMT
nacx commented on this pull request.



> +/**
+ *
+ */
+@AutoValue
+public abstract class MetricData {
+
+   /**
+    * The timestamp for the metric value in ISO 8601 format.
+    */
+   public abstract Date timeStamp();
+
+   /**
+    * The average value in the time range
+    */
+   @Nullable
+   public abstract String total();

I still think a `Number` makes more sense. Having a number with `.0` decimal is not a big
deal, as you can still do arithmetic operations, etc, normally. Letting the users how to parse
them propagates unnecessary complexity to them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/396#discussion_r124302494
Mime
View raw message