jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Improve duplicate ssh key check in Packet (#397)
Date Thu, 15 Jun 2017 08:05:08 GMT
nacx commented on this pull request.

+      PublicKey userKey = readPublicKey(options.getPublicKey());
+      final String fingerprint = computeFingerprint(userKey);
+      synchronized (CreateSshKeysThenCreateNodes.class) {

To avoid race conditions on this "getOrCreate" method. You could have apps/clients accessing
the same project with different API keys (that is, two different jclouds contexts), and race
conditions could appear here.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
View raw message