jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Improve duplicate ssh key check in Packet (#397)
Date Thu, 15 Jun 2017 08:06:18 GMT
nacx commented on this pull request.



>  
+      PublicKey userKey = readPublicKey(options.getPublicKey());
+      final String fingerprint = computeFingerprint(userKey);
+      
+      synchronized (CreateSshKeysThenCreateNodes.class) {
+         boolean keyExists = api.sshKeyApi().list().concat().anyMatch(new Predicate<SshKey>()
{

No. The parameter to the `get` method is the "name" of the key. It happens that we were setting
the fingerprint as the name when creating the keys (for convenience), but the old implementation,
that already did this, was not able to find keys with normal names. We need to inspect the
fingerprint field of all keys.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/397#discussion_r122142625
Mime
View raw message