jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject [jclouds/jclouds-labs] Improve duplicate ssh key check in Packet (#397)
Date Wed, 14 Jun 2017 10:35:23 GMT
@andreaturli please review.

Apologies for the noise in the PR; I've formatted the class to 3-space indent. There is a
small set of changes:

* Generate a unique name for the generated key pair if the user does not provide a key. We
were generating them with repeated names.
* Improve the check for the key existence (keys can't be duplicated in Packet). previously
we just checked the names. Now the code checks the fingerprints of existing keys to determine
if it already exists or not.
* When cleaning up the ssh keys, just delete the ones generated by jclouds, but do not delete
any pre-existing key that might be used. if it was there, we leave it there.
* Synchronized the key check and creation to avoid race conditions in concurrent environments.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/397

-- Commit Summary --

  * Improve duplicate ssh key check in Packet

-- File Changes --

    M packet/src/main/java/org/jclouds/packet/compute/strategy/CreateSshKeysThenCreateNodes.java
(289)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/397.patch
https://github.com/jclouds/jclouds-labs/pull/397.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/397

Mime
View raw message