jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vikas Rangarajan <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-1304: add azure customdata, JCLOUDS-1305: add support for ssh keys in keyvault (#398)
Date Wed, 12 Jul 2017 16:03:10 GMT
Hello @nacx - need your input on implementation for keyvault support. The azure compute adapter
code was refactored to use the VirtualMachineAPI instead of the deployment API. As  a result,
keyvaults cannot be accessed merely by reference (as we could in the deployment template).
So - I think we need to implement a new "feature" for azurecompute-arm - namely the keyvault
API (https://docs.microsoft.com/en-us/rest/api/keyvault/). So I think we should restrict this
PR to just "custom data" support" and remove the keyvault refs. Then create a new issue for
keyvault support. Thoughts? Thanks much!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/398#issuecomment-314816527
Mime
View raw message