jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Generate Azure VM password on the fly (#402)
Date Tue, 18 Jul 2017 06:29:22 GMT
nacx commented on this pull request.

> + *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.util;
+import com.google.common.io.BaseEncoding;
+import java.util.Random;
+// Seems to be a common theme between providers, perhaps should be provided by core (see
other 'Passwords' classes)
+public class Passwords {

Sure they are. For me, it would make sense to refactor this class out to jclouds-compute and
provide several generic methods to generate passwords, with their corresponding tests. Providers
should be able to use the ones that match their policies, but this class is definitely a good
fit for jclouds-compute. Users would be able to easily use it too in a portable way.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
View raw message