jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Spring <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Subscription ID wasn't being substituted (#406)
Date Fri, 28 Jul 2017 15:20:44 GMT
It makes sense.

I'll plumb it into the pr today.


On Jul 28, 2017 12:12 AM, "Ignasi Barrera" <notifications@github.com> wrote:

> I think this
> <https://github.com/jclouds/jclouds-labs/commit/17f7c4528472c87799df28512b7a97571f11f625>
> is the offending commit.
> Having the property makes it easier to create the context. Following the
> same pattern, it would be good to also preset the oauth.endpoint property
> by default in the provider metadata default properties with a placeholder
> for the tenantId to be substituted the same way. WDYT? This way users
> will only have to set the two properties and the credentials (and they'll
> still be able to configure the entire endpoints if they want to).
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/jclouds/jclouds-labs/pull/406#issuecomment-318579277>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAHljhdu28xiL9zO7Gvdrs3O6gImefV2ks5sSYnXgaJpZM4OlxeV>
> .

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
View raw message