jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoff Macartney <notificati...@github.com>
Subject Re: [jclouds/jclouds] [JCLOUDS-1318] fix based on nodeTerminatePredicate (#1117)
Date Fri, 07 Jul 2017 10:52:29 GMT
geomacy commented on this pull request.



> @@ -95,6 +101,7 @@ public Boolean apply(String id) {
       }
 
       boolean serverDeleted = novaApi.getServerApi(regionAndId.getRegion()).delete(regionAndId.getId());
+      checkState(nodeTerminatedPredicate.apply(id), "server was not destroyed in the configured
timeout");

Is it desirable to throw an exception here, or should we just log a warning? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#pullrequestreview-48575884
Mime
View raw message