jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds] [JCLOUDS-1318] fix based on nodeTerminatePredicate (#1117)
Date Fri, 07 Jul 2017 11:08:04 GMT
andreaturli commented on this pull request.



> @@ -95,6 +101,7 @@ public Boolean apply(String id) {
       }
 
       boolean serverDeleted = novaApi.getServerApi(regionAndId.getRegion()).delete(regionAndId.getId());
+      checkState(nodeTerminatedPredicate.apply(id), "server was not destroyed in the configured
timeout");

Thinking about it more, I guess `destroyNode` should not invoke `CleanUpServer` but simply
```
      boolean serverDeleted = novaApi.getServerApi(regionAndId.getRegion()).delete(regionAndId.getId());
      checkState(nodeTerminatedPredicate.apply(id), "server was not destroyed in the configured
timeout");
```
as `CleanUpServer` will be invoked by https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeService.java#L99
anyways. I'll test it, meanwhile wdyt?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#discussion_r126122879
Mime
View raw message