jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoff Macartney <notificati...@github.com>
Subject Re: [jclouds/jclouds] [JCLOUDS-1318] fix based on nodeTerminatePredicate (#1117)
Date Tue, 11 Jul 2017 14:16:28 GMT
geomacy approved this pull request.

LGTM at a quick read. Still have a feeling it shouldn't throw exceptions if `destroyNode`
fails but will defer to you on this.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#pullrequestreview-49209337
Mime
View raw message