jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Svet <notificati...@github.com>
Subject Re: [jclouds/jclouds] Use separate credential stores per context (#1119)
Date Thu, 13 Jul 2017 14:31:27 GMT
@nacx That's a great idea, thanks for the example.

Don't disagree having the shared cache could be useful. It's the way it's used in [GetLoginForProviderFromPropertiesAndStoreCredentialsOrReturnNull](https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/config/GetLoginForProviderFromPropertiesAndStoreCredentialsOrReturnNull.java)
that I don't like. And that's used in all providers.

Having the configuration of one compute service affect all remaining compute services even
when they have different configuration is surprising to say the least :)

I still think that it's the wrong thing to do. Perhaps it should be the other way around -
users which really need the cross-service cache should inject it themselves.

Can you give some good examples of using the cache? From looking at the code it seems that
its not even needed - no heavy computation is done to extract the username/password in the
default case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1119#issuecomment-315095395
Mime
View raw message