jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chaithanya Ganta <notificati...@github.com>
Subject Re: [jclouds/jclouds] Remove Expect header for PUT and POST reqs with content-length=0 (#1120)
Date Mon, 17 Jul 2017 16:18:17 GMT
ChaithanyaGK commented on this pull request.



> @@ -357,6 +357,22 @@ public GeneratedHttpRequest apply(Invocation invocation) {
       if (request.getPayload() != null) {
          contentMetadataCodec.fromHeaders(request.getPayload().getContentMetadata(), headers);
       }
+
+      boolean isEmptyBody = false;
+      if ("POST".equals(requestMethod) || "PUT".equals(requestMethod)) {

@nacx Mostly, I came across Expect header being set for either POST or PUT request. But, I
couldn't find any mention of that Expect header is restricted to some Http methods. I think
we can remove this check altogether. WDYT ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1120#discussion_r127745941
Mime
View raw message