jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds/jclouds] Remove Expect header for PUT and POST reqs with content-length=0 (#1120)
Date Tue, 18 Jul 2017 05:20:24 GMT
andrewgaul requested changes on this pull request.

Which existing integration test exercises this code path?  If none exists, please add one.
 Also post the results from some real providers.

> @@ -73,7 +73,7 @@ public void testZeroLengthPutHasContentLengthHeader() throws IOException,
Interr
       RecordedRequest request = server.takeRequest();
       assertEquals(request.getRequestLine(), "PUT /bucket/object HTTP/1.1");
       assertEquals(request.getHeaders(CONTENT_LENGTH), ImmutableList.of("0"));
-      assertEquals(request.getHeaders(EXPECT), ImmutableList.of("100-continue"));
+      assert request.getHeaders(EXPECT).isEmpty();

Call `assertThat(request.getHeaders(EXPECT).isEmpty())`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1120#pullrequestreview-50510182
Mime
View raw message