jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Parenthesize confusing conditional (#407)
Date Wed, 02 Aug 2017 00:27:11 GMT
andrewgaul commented on this pull request.



> @@ -49,9 +49,12 @@ public void handleError(HttpCommand command, HttpResponse response)
{
          case 400:
             if (message.contains("RESOURCE_NOT_FOUND") || message.contains("OPERATION_NOT_SUPPORTED"))
{
                exception = new ResourceNotFoundException(message, exception);
-            } else if (message.contains("INVALID_INPUT_DATA") || message.contains("ORGANIZATION_NOT_VERIFIED")
-                  || message.contains("SYSTEM_ERROR") && !message.contains("RETRYABLE_SYSTEM_ERROR")
|| message
-                  .contains("CPU_SPEED_NOT_AVAILABLE") || message.contains("CONFIGURATION_NOT_SUPPORTED"))
{
+            } else if ((message.contains("CONFIGURATION_NOT_SUPPORTED") ||
+                  message.contains("CPU_SPEED_NOT_AVAILABLE") ||
+                  message.contains("INVALID_INPUT_DATA") ||
+                  message.contains("ORGANIZATION_NOT_VERIFIED") ||
+                  message.contains("SYSTEM_ERROR")) &&
+                  !message.contains("RETRYABLE_SYSTEM_ERROR")) {

The intent is not clear to me.  @jawnclarke?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/407#discussion_r130761623
Mime
View raw message