jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From code4clouds <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)
Date Thu, 02 Nov 2017 13:33:15 GMT
code4clouds commented on this pull request.



> +   /**
+    * The private IP address version of the Virtual Machine Scale Set Ip Configuration Properties
+    */
+   @Nullable
+   public abstract String privateIPAddressVersion();
+
+   /**
+    * The load balancer backend address pools of the Virtual Machine Scale Set Ip Configuration
Properties
+    */
+   @Nullable
+   public abstract List<IdReference> loadBalancerBackendAddressPools();
+
+   /**
+    * The load balancer inbound nat pools of the Virtual Machine Scale Set Ip Configuration
Properties
+    */
+   @Nullable

Hi @nacx  I should have been more clear and place the mock error in the right comment section.
 This is the file with the @nullable that I was referring when talking about the mocks failing.
 I removed the others as you suggested, but the ones in this file seems they need to stay.

This is the error:
```testVMSSGet_StorageProfile(org.jclouds.azurecompute.arm.features.VirtualMachineScaleSetApiMockTest)
 Time elapsed: 0.035 sec  <<< FAILURE!
org.jclouds.http.HttpResponseException: Error parsing input: Null loadBalancerInboundNatPools```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/412#discussion_r148532591
Mime
View raw message