jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Add tags to virtual network creation (#417)
Date Mon, 06 Nov 2017 15:10:32 GMT
andreaturli commented on this pull request.

> @@ -159,7 +159,7 @@ protected synchronized void createDefaultNetworkIfNeeded(String group,
String lo
          logger.debug(">> network options have not been configured. Creating network
%s(%s) and subnet %s(%s)", name,
                defaultVnetAddressPrefix, name, defaultSubnetAddressPrefix);
-         api.getVirtualNetworkApi(options.getResourceGroup()).createOrUpdate(name, location,
+         api.getVirtualNetworkApi(options.getResourceGroup()).createOrUpdate(name, location,
null, properties);

sure, that makes sense!
would it make sense to think about a default strategy to tag the `virtualNetwork` so the clean
up resources step can take advantage of it?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
View raw message