jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)
Date Thu, 15 Feb 2018 11:02:21 GMT
andreaturli commented on this pull request.



> +   }
+
+   private final Location location;
+
+   @Inject
+   public NeutronFloatingIpToFloatingIp(@Assisted Location location) {
+      this.location = location;
+   }
+
+   @Override
+   public FloatingIP apply(@Nullable org.jclouds.openstack.neutron.v2.domain.FloatingIP floatingIP)
{
+      FloatingIP.Builder<?> builder = FloatingIP.builder();
+      builder.id(floatingIP.getId());
+      builder.ip(floatingIP.getFloatingIpAddress());
+      builder.fixedIp(floatingIP.getFixedIpAddress());
+      builder.instanceId(floatingIP.getPortId());

ouch this function is not used anyway, so I'll remove it

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1178#discussion_r168442933
Mime
View raw message