jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William L Thomson Jr <notificati...@github.com>
Subject Re: [jclouds/jclouds] core: Fix compile issue under Java 8+ (#1180)
Date Fri, 16 Feb 2018 08:19:34 GMT
@nacx are you getting that failure with my patches or in general?

Like in the [compute package](https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/jclouds-compute/jclouds-compute-9999.ebuild#L55)
I made. I had to change the static imports to regular usage. I guess that maybe a compiler
bug/issue. The Class names can vary, as I saw it mixing Functions with Function. Though I
found a [Function class in guava](https://github.com/google/guava/blob/master/guava/src/com/google/common/base/Function.java)
that was inheriting [Java internal Function](https://docs.oracle.com/javase/9/docs/api/java/util/function/Function.html#compose-java.util.function.Function-).
It was still mixing [guava Functions](https://github.com/google/guava/blob/master/guava/src/com/google/common/base/Functions.java)
with internal Function. Thus this PR.

I suspect there are many things like that. Short of relying on the compiler. I would just
remove static imports and change usage. Unless there is some reason for them to be static.
Just seems like shorthand to get at the methods. Vs typing the class name over and over. Maybe
more to it though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1180#issuecomment-366170658
Mime
View raw message