jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds] core: Fix compile issue under Java 8+ (#1180)
Date Fri, 16 Feb 2018 09:27:28 GMT
jclouds builds fine with Java 8. The problem arises when using Java 8 with Guava >= 21.0.
The pull request builder does not force a concrete Guava version and builds the project with
the default jclouds one, that's why the build succeeded.

You can easily reproduce the issue by passing the `-Dguava.version=21.0` to the Maven build
to force a concrete version of Guava.

I've tried building the pull request with `oracle64-1.8.0.91` and `oracle64-1.8.0.162`, and
using Guava 21.0, 22.0 and 24.0-jre. Always the same failure:

```bash
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ jclouds-core ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 358 source files to /home/ibarrera/src/asf/jclouds/core/target/classes
/home/ibarrera/src/asf/jclouds/core/src/main/java/org/jclouds/reflect/Reflection2.java:199:
error: <anonymous org.jclouds.reflect.Reflection2$5$1> is not abstract and does not
override abstract method test(Invokable<?,?>) in Predicate
               Optional<Invokable<?, ?>> constructor = Iterables.tryFind(constructors,
new Predicate<Invokable<?, ?>>() {
                                                                                         
                              ^
/home/ibarrera/src/asf/jclouds/core/src/main/java/org/jclouds/reflect/Reflection2.java:267:
error: <anonymous org.jclouds.reflect.Reflection2$7$1> is not abstract and does not
override abstract method test(Invokable<?,?>) in Predicate
               Optional<Invokable<?, ?>> method = Iterables.tryFind(methods, new
Predicate<Invokable<?, ?>>() {
                                                                                         
                    ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors
```

Can you try building the pull request using Guava 21.0, as mentioned in my previous comments?
Obviously using an *unpatched* version of Guava or any other library jclouds depends on.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1180#issuecomment-366184527
Mime
View raw message