jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William L Thomson Jr <notificati...@github.com>
Subject Re: [jclouds/jclouds] core: Fix compile issue under Java 8+ (#1180)
Date Fri, 16 Feb 2018 17:59:56 GMT
For some reason usage is not inheriting [guava Predicate](https://github.com/google/guava/blob/master/guava/src/com/google/common/base/Predicate.java#L78)
implementation of [test](https://docs.oracle.com/javase/9/docs/api/java/util/function/Predicate.html#test-T-).


This is really a mess, CI gives different failures than locally... What is going on with that?

Not sure what to say on guava versions but you all need to figure stuff out. You cannot support
that many versions of guava with API changes. Like the removal of ```getHostText``` and ```getHost```
not being in < guuva 20. Also seems trying to support older targets has issues. I had odd
maven failures with ```-Dmaven.compile.source=1.8 -Dmaven.compile.target=1.8```. Ended up
running without which I guess uses target 1.6.

Not sure how much more time i want to spend on this. I have already fixed my issues. This
seems like a can of works for JClouds. I also do not understand why the legacy guava and targets.
It will cause issues like this as things move forward.

I would recommend at least requiring quava 22 and source/target 1.8.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1180#issuecomment-366311198
Mime
View raw message