jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ali Bazlamit <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
Date Thu, 29 Mar 2018 14:34:38 GMT
alibazlamit commented on this pull request.



> @@ -53,7 +53,7 @@ public Hardware apply(HardwareFlavour from) {
       }
       final HardwareBuilder builder;
       builder = new HardwareBuilder()
-              .ids(from.id())
+              .ids(from.name())

My first approach was what you have suggested, for some reason the API has similiar Id's between
the baremetal flavors and the cloud flavors, the only thing to make them unique is the name
so far, this might be an issue on the API side that might get changed in the future, if that
ever happens we can go with what you suggested

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#discussion_r178075870
Mime
View raw message